-
Notifications
You must be signed in to change notification settings - Fork 245
Lost password feature #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
FalkWolsky
merged 21 commits into
lowcoder-org:dev
from
irfan-ikhwa:lost-password-feature
Mar 14, 2024
Merged
Lost password feature #755
FalkWolsky
merged 21 commits into
lowcoder-org:dev
from
irfan-ikhwa:lost-password-feature
Mar 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blic url env variable and some code optimizations.
👷 Deploy request for lowcoder-cloud pending review.Visit the deploys page to approve it
|
👷 Deploy request for lowcoder-test pending review.Visit the deploys page to approve it
|
FalkWolsky
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this great contribution. So many users did wait for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds the feature to allow users to request a password reset email. Following are the details.
There are 2 APIs in this, Following are the details
It takes a
RequestBody
of typeLostPasswordRequest
which contains theuserEmail
field. Following is the detailed flow step by stepINVALID_PARAMETER
and the flow ends herefindByName
function.PASSWORD_RESET_EMAIL_TEMPLATE
.generateNewRandomPwd
mailCommunicationService
org.springframework.mail.javamail.JavaMailSender
to send the emailRequestBody
of typeResetLostPasswordRequest
which containstoken
,userEmail
, andnewPassword
. Following is the detailed flow step by step.INVALID_PARAMETER
and flow ends hereTOKEN_EXPIRED
INVALID_TOKEN
.Environment Variables Introduced
LOWCODER_ADMIN_SMTP_HOST
-> This is the host for SMTP serverLOWCODER_ADMIN_SMTP_PORT
-> This is the port for SMTP serverLOWCODER_ADMIN_SMTP_USERNAME
-> This is the email / username used for SMPT authenticationLOWCODER_ADMIN_SMTP_PASSWORD
-> This is the password used for the SMTP authenticationLOWCODER_ADMIN_SMTP_SSL_ENABLED
-> This enables the SSL authenticationLOWCODER_ADMIN_SMTP_STARTTLS_ENABLED
-> This enables STARTTLS authenticationThings to Consider
LOWCODER_ADMIN_SMTP_SSL_ENABLED
andLOWCODER_ADMIN_SMTP_STARTTLS_ENABLED
can be set toTRUE
at a time.LOWCODER_ADMIN_SMTP_PORT
should be set according to the authentication method used.Types of changes
What types of changes does your code introduce to Lowcoder?
Put an
x
in the boxes that apply.Checklist
You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
Put an
x
in the boxes that apply.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc.